Fixes clean_old_storages_with_reclaims tests #4147
Conversation
brooksprumo
force-pushed
the
clean-old-storages
branch
from
6d678f2 to
6dfc7d5
Compare
brooksprumo
added
the
automerge
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
(cherry picked from commit 4eabeed) # Conflicts: # accounts-db/src/accounts_db/tests.rs
|
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
(cherry picked from commit 4eabeed) # Conflicts: # accounts-db/src/accounts_db/tests.rs
#4165) * Fixes clean_old_storages_with_reclaims tests (#4147) (cherry picked from commit 4eabeed) # Conflicts: # accounts-db/src/accounts_db/tests.rs * fix merge conflicts --------- Co-authored-by: Brooks <[email protected]>
#4166) * Fixes clean_old_storages_with_reclaims tests (#4147) (cherry picked from commit 4eabeed) # Conflicts: # accounts-db/src/accounts_db/tests.rs * fix merge conflicts --------- Co-authored-by: Brooks <[email protected]>
Problem
The two accounts-db
clean_old_storages_with_reclaimstests incorrectly set up the dirty stores/uncleaned pubkeys to test out the desiredcleansituations. This is becauseuncleaned_rootsis used, but this struct is not responsible for deciding which slots to load as clean candidates.Summary of Changes
Fixes the tests to not use uncleaned_roots.